search

osate / osate-ge

Old Graphical editor for OSATE repository, kept for reference
6 stars 3 forks source link

Wrong icons for access features #304

Closed lwrage closed 6 years ago

lwrage commented 6 years ago

Icons in OSATE don't conform to the AADL standard. 15196799187241443617919

lwrage commented 6 years ago

I fixed the icons in the outline, and the same icons are used in the palette. This leaves the issue that data access features are not filled in the graphical editor.

philip-alldredge commented 6 years ago

Do you have a reference? It may be an inconsistency in the standard or perhaps I'm looking at an older version.

"The same symbol is used to represent access to bus and to data. Figure 35 illustrates the graphical notation to represent sharing of data." Figure 35 does not show it as filled.

lwrage commented 6 years ago

8.6 figure 12. At the SEI we have always used the version from that diagram. I'm not sure what was intended. The AADL book uses the outline version for both, so we can just standardize on that for OSATE. I'll adjust the icons to match the graphical editor.