Closed philip-alldredge closed 2 years ago
As part of improving the graphical editor support in #1217, additional experimentation was done with subversion. Subclipse appears to handle locking better than subversive. There were occasional NPE when refactoring in the graphical editor with subversive.
Subclipse will try to automatically lock files in most cases. However, if subclipse fails to lock the file due to it already being locked, it will just output a message to the console. However, the message will describe the cause so from a user perspective, I believe subclipse provides the best experience. There may not be anything that is needed to do beyond the enhancements as part of #1217 other than recommend subclipse as the SVN plugin.
@philip-alldredge Is there anything that needs to be done except documenting that OSATE doesn't work with subversive?
I don't know of anything else that can be done other than discourage subversive use. I haven't checked this lately so I don't know if subversive's behavior has changed.
Summary
Expected and Current Behavior
When using OSATE with a subversion project that has the needs-lock property, an error can occur while renaming elements if the source file is not locked for editing. When manually editing a file, Eclipse will prompt to lock the file when saving. However, when refactoring, Eclipse will not prompt. An error is shown. Similiar issues affect the graphical editor.
Steps to Reproduce
This may not be a minimal model or steps but I was able to reproduce by doing the following.
Environment