osate / osate2

Open Source AADL2 Tool Environment
http://osate.org
Eclipse Public License 2.0
36 stars 8 forks source link

OSATE Graphical Editor should move bend points when both ends are moved together #1476

Closed smithdtyler closed 5 years ago

smithdtyler commented 6 years ago

When I select a group of objects in an AADL diagram and move them, anchor points on flows and connections between the objects don't move with them. By anchor points I'm referring to "turns" in the line connecting the two objects.

When both objects connected by a flow/connection/etc are moved, all anchor points on that flow/connection should move too.

philip-alldredge commented 6 years ago

To clarify things: this affects when the container itself isn't moving. For example, when two subcomponents move, the connection isn't updated. However, when the container is moved then the connections are updated appropriately. Is this correct?

smithdtyler commented 6 years ago

@philip-alldredge not quite. Here's an example of the problem with pictures:

  1. Start from the example producer-consumer model:

screen shot 2018-08-23 at 10 16 52 am

  1. Select the two processes and drag them down.

screen shot 2018-08-23 at 10 17 17 am

  1. The anchor on the connection between them does not move.

screen shot 2018-08-23 at 10 17 26 am

This even happens when I select the connection

screen shot 2018-08-23 at 10 17 34 am

screen shot 2018-08-23 at 10 17 41 am

smithdtyler commented 6 years ago

What should happen is the arrow should maintain its shape, as (mocked up) below: screen shot 2018-08-23 at 10 16 52 am screen shot 2018-08-23 at 10 21 59 am

philip-alldredge commented 6 years ago

I think we are in agreement. Your example is the same as I (attempted) to describe in my comment. I was trying to clarify the case where the issue occurs. However, your example does a good example at illustrating it.

philip-alldredge commented 5 years ago

We also need to consider how the implementation of this affects the alignment tools and other tools that perform shape movement.