Experimental visualization and editing capability for EMV2 flow propagations

[philip-alldredge]

This issue has been revised multiple times to more accurately describe the changes being made

• [x] Type Library:
  • [x] Rework current implementation. Remove GE dummy model object. No separate graphical element. Types will be contained directly in packages.
  • [x] Palette commands. Automatically add imports as needed.
    • [x] Error type.
    • [x] Error type alias. Prompt on create.
    • [x] Error type set. Can't be empty. Prompt for type contents when settings.
    • [x] Error type set alias. Prompt on create.
  • [x] Basic diagram support
  • [x] Property section.
    • [x] Allow setting extended type libraries.
    • [x] Set type extension
    • [x] Set error type set type tokens
    • [x] Change alias for error type
    • [x] Change alias for error type set
• [x] Implement visualizations
  • [ ] ~Implement mechanism for business object providers or business object handlers to contribute dependent objects. For now, just assume that an object with the same container is being contributed. Use relative references. This is needed to ensure that things like the diagram element for keywords exist when they are referenced.~
  • [x] Keyword Propagation Point(Internal enumeration) - Classifiers and Subcomponents. Shape TBD. These are elements for keywords that "any", "access, "binding", etc that act similar to propagation points.
  • [x] Propagation Point - Classifiers and Subcomponents. Shape TBD.
  • [x] Propagation and Containment - Keyword Propagation Point, Feature, Propagation Point - Label
  • [x] Error Propagation Paths - Classifiers and Subcomponents - Connection. This only includes explicitly modeled error propagation paths.
  • [x] Error Flow Declaration - Classifiers and Subcomponents - Connection
  • [x] Investigate layout issues. Layout of cycles for error flow declaration. All -> All.
• [x] Creation and editing
  • [x] Propagation Point - Renaming, Deletion, Palette.
  • [x] Propagation and Containment - Palette. Deletion. Property Section on propagation point. Consider. Adjusting flags will update references since they do not have names.
  • [x] Error Propagation Paths - Renaming, Deletion, Palette
  • [x] Error Flow Declaration - Renaming, Deletion, Palette and Property Section
  • [x] Automated tests
• [x] Other
  • [x] Consider adding tooltips
  • [ ] ~Ensure copy and paste works for EMV2 elements.~
  • [x] Consider adding diagram types. Error Type Library, Error Flow, etc.
  • [x] Add additional filters as needed. Could track whether a keyword and are referenced and have a referenced keyword filter?
  • [x] Review labels for filters
  • [x] Review palette
  • [x] Review state machine support. While state machine support is outside the scope of this task, it needs to be stable enough to be included with the plugin. Otherwise, it needs to be removed.
  • [x] Review all used graphics and annotations and refine. It would be preferred to not use "Annotation" labels as these cannot be removed and may clutter up the diagram. However, in cases of ambiguity, there needs to be a way to distinguish from exciting model elements.

References

• Error Propagation and Error Containment Declarations(E.7.1)
• Error Propagation Paths and User-defined Propagation Points and Paths(E.7.3)
• Error Flow Declarations(E.7.2)

Examples

• https://github.com/osate/examples/blob/63382782288fcc085432067d85f4ef894c858a96/EMV2TR_Test_Files/AppSystem.aadl

[philip-alldredge]

My understanding based on the standard documentation is that although a classifier may have multiple EMV2 annex sub clauses each with "in modes" statement, they do not impact the EMV2 model elements that this issue covers. The general approach is to treat the model as if the model elements are in the same subclause.

[philip-alldredge]

Support for dependent objects will not be added to the graphical editor. Additional design and consideration is needed to determine whether that is really the best way to solve the issue of connection endpoints being missing from the diagram. Automatically adding endpoints for some or all connections would not be consistent with the current behavior and could result in automatic changes to serialized diagrams. There are cases where a user may want to avoid adding such diagram elements. Lastly, it would be a significant change to the diagram update process with a potential performance impact. If/when the problem is solved, it may be better to include it as part of a refinement or rework of the content filter system.

[philip-alldredge]

@lwrage given how close we are to the next planned release, we have removed the part about promoting the EMV2 support out of experimental from this issue. This will give us more time to ensure things are reliable. We've moved the latter part to #2450.

[philip-alldredge]

Copying and pasting will not be supported for error model elements at this time. How they are represented is not compatible with the current copying and pasting implementation a new issue will be added to the backlog.