Fault Tree Analysis has an infinite loop / gives an unhandled event loop exception

sprocter commented 4 years ago

Summary

I'm trying to compute a fault tree for part of an aircraft's wheel braking system, but getting an error that there's an infinite loop / stack overflow occurring.

Expected and Current Behavior

Expected: OSATE should generate and display a fault tree.

Actual: A popup box titled "Problem Occurred" appears, and says:

Unhandled event loop exception java.lang.StackOverflowError

The terminal fills up with these lines:

    at org.osate.aadl2.errormodel.faulttree.generation.FTAGenerator.optimizeGates(FTAGenerator.java:543)
    at org.osate.aadl2.errormodel.faulttree.generation.FTAGenerator.optimizeGates(FTAGenerator.java:543)
    at org.osate.aadl2.errormodel.faulttree.generation.FTAGenerator.optimizeGates(FTAGenerator.java:543)

Steps to Reproduce

Load the "GTSE-Examples" project from the GATSE repo into OSATE
Instantiate the bscu.generic system implementation, which is located in GTSE-Examples/ARP4761/advanced/implementation/bscu.aadl
Run the Fault Tree Analysis tool on the model with the following (default) settings:

Environment

OSATE Version: OSATE is built from source. I'm on the master branch; the most recent commit is fafd82c38837a4749b778656746156e3a390c4ab.
Operating System: Mac OS 10.14.6

lwrage commented 4 years ago

The exception happens in OSATE 2.5.1, already, so this is not a newly introduced bug.

reteprelief commented 4 years ago

Addressed by fix for issue #2123 in pull request #2135

osate / osate2