search

osate / osate2

Open Source AADL2 Tool Environment
http://osate.org
Eclipse Public License 2.0
38 stars 8 forks source link

Deletion of device in graphical editor does not remove corresponding connection in text #2117

Closed jjhudak closed 1 year ago

jjhudak commented 4 years ago

Summary

In an implementations, a system with a FG is connected to a device with a corresponding FG. In the graphical editor, if you delete the device, the associated connection vanishes. (seems reasonable). If you then go to the corresponding textual representation, the device subcomponent is gone, but the connection still is present (should be deleted?), and is marked with an error (as it should). In this example, I cannot think of any reason why the connection statement still should remain in the connections subclause.

Expected and Current Behavior

Expected behavior: in the graphical view of a implementation, if the device with a single FG connection to another system is removed, along with its connection, I expect the connection in the textual representation to be removed as well.

Current behavior: The connection remains in the connections subclause in the textual representation and is marked with an error.

Steps to Reproduce

  1. Use the attached model, in the implementation mycar.cruisecontrol, delete the throttle actuator in the graphical editor and observe results in graphical and textual representations
Paste your model here

Environment

philip-alldredge commented 4 years ago

This is a subset of #1206. The general solution is a difficult problem. However, a limited capability could be implemented without too much difficulty if it was limited to only deleting elements in the same component implementation that contains the subcomponent. That is, if it did not look at extended implementations at this time.

Thoughts?

jjhudak commented 4 years ago

Hi Phil: I didn’t realize it was part of another issue. Yes, I didn’t consider the related issues in deleting. Maybe the simple case as you pointed out would be reasonable. Would have to balance out the amount of work and all the places the rework would need to be done. Perhaps just putting up a info box that the user will have to manually remove all related connections? Yes, they would eventually discover it but at least they were warned.

John From: philip-alldredge notifications@github.com Sent: Tuesday, December 17, 2019 3:27 PM To: osate/osate2 osate2@noreply.github.com Cc: John J Hudak jhudak@sei.cmu.edu; Author author@noreply.github.com Subject: Re: [osate/osate2] Deletion of device in graphical editor does not remove corresponding connection in text (#2117)

This is a subset of #1206https://github.com/osate/osate2/issues/1206. The general solution is a difficult problem. However, a limited capability could be implemented without too much difficulty if it was limited to only deleting elements in the same component implementation that contains the subcomponent. That is, if it did not look at extended implementations at this time.

Thoughts?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/osate/osate2/issues/2117?email_source=notifications&email_token=AEUTKY6VKZHPLRI2NSX2G7DQZEYXNA5CNFSM4J4AMKIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHD3BEI#issuecomment-566734993, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEUTKY55TO26UMIOEKAZJPTQZEYXNANCNFSM4J4AMKIA.