search

osate / osate2

Open Source AADL2 Tool Environment
http://osate.org
Eclipse Public License 2.0
36 stars 8 forks source link

Renaming property set drops property set prefix from references to constants #2223

Closed lwrage closed 4 years ago

lwrage commented 4 years ago

Summary

When renaming a property set with rename refactoring property constants that are defined and used in this property set lose their property set name prefix.

Steps to Reproduce

  1. Paste the model below in the AADL text editor
  2. Place the cursor on the property set name and hit Alt+Shift+R
  3. Change the property set name to PS1
  4. References to constant C1 are now C1 instead of PS1::C1
property set PS is
    C1: constant aadlinteger => 0;
    -- errors in the following 2 lines 
    C2: constant aadlinteger => PS::C1;
    P1: aadlinteger => PS::C1 applies to (all);
end PS;

Environment

lwrage commented 4 years ago

Content assist also inserts constant without property set name prefix, so it's a scoping bug.