osate / osate2

Open Source AADL2 Tool Environment
http://osate.org
Eclipse Public License 2.0
39 stars 8 forks source link

Connection instance doesn't continue inside processor #2298

Open smithdtyler opened 4 years ago

smithdtyler commented 4 years ago

Expected and Current Behavior

Connections on subcomponents (C1 below) are not appearing in the instance model.

Steps to Reproduce

Instantiate top.impl in the model below

package MissingConnection
public
    processor proc
        features
            proc_in: in data port;
    end proc;

    processor implementation proc.impl
        subcomponents
            vp1: virtual processor vproc;
        connections
            C1: port proc_in -> vp1.vproc_in;
    end proc.impl;

    virtual processor vproc
        features
            vproc_in: in data port;
    end vproc;

    device network
        features
            net_port: in out data port;
    end network;

    system top
    end top;

    system implementation top.impl
        subcomponents
            p1: processor proc.impl;
            n1: device network;
        connections
            S1: port n1.net_port -> p1.proc_in;
    end top.impl;
end MissingConnection;

Environment

lwrage commented 4 years ago

The description of the issue is way too broad. This happens only inside (virtual) processors. There is an explicit check to stop connections at a (virtual) processor boundary.

lwrage commented 4 years ago

@smithdtyler Do you really need this for something?

smithdtyler commented 4 years ago

@smithdtyler Do you really need this for something?

To my knowledge this is not an urgent issue.

smithdtyler commented 4 years ago

@smithdtyler Do you really need this for something?

To my knowledge this is not an urgent issue.

However, The AADL book, in the example on p. 178, presents a modeling idiom that exposes this bug.