philip-alldredge
commented
4 years ago @lwrage from my perspective this is a core issue rather than a graphical editor issue even though it likely primarily affects the graphical editor.
Closed philip-alldredge closed 3 years ago
philip-alldredge
commented
4 years ago @lwrage from my perspective this is a core issue rather than a graphical editor issue even though it likely primarily affects the graphical editor.
lwrage
commented
4 years ago I think we can delete the requirement for a write transaction. IIRC, it's a leftover from before using Xtext.
philip-alldredge
commented
4 years ago That would be very helpful. This used to work but something changed that caused this to start becoming an issue. We'll have annex related tests in the graphical editor in the near future which should catch any regressions.
philip-alldredge
commented
4 years ago Is this something that could be fixed by the next release? As it is, it can cause issues by just having and annex subclause or library in a model.
philip-alldredge
commented
4 years ago @lwrage I was able to confirm that this does not occur in the current stable version of OSATE.
lwrage
commented
4 years ago This is not related to the transactional editing domain used in core OSATE so the above comment about removing the transaction requirement is invalid.
The root cause for this issue is the need for re-parsing the EMV2 annex to format it. This can be avoided only by creating a new AnnexParser interface for use by annexes that are based on Xtext. The current interface must be kept because the BA implementation is not Xtext based.
philip-alldredge
commented
4 years ago You are likely already aware of this, but this issue occurs regardless of whether the annex is even has a parser. Since the parsedAnnexSubclause/Library is set, the transaction error occurs.
Summary
An exception is thrown when saving an xtext resource which contains an AADL annex due to the lack of a write transaction. The AADL formatter re-parses the annex and updates the parsed annex which causes an exception.
In practice, this can occur when using the graphical editor if the xtext editor is not open. The graphical editor may run the formatter when getting the AADL text before and after a modification. All of the graphical editor's modifications are performed in an EMF transaction. I don't think the graphical editor should need to perform all saves in a write transaction.
Expected and Current Behavior
When formatting/saving a model with an annex in it, no exception should be thrown. An exception is thrown because the formatter is modifying the model so update the parsed annex library/subclause contained in the model as part of the formatting operation.
Steps to Reproduce
Environment