Missing validation for feature connections

[lwrage]

Summary

Data types on ports are not validated if the ports are connected with a feature connection.

Expected and Current Behavior

Feature connections should be validated like port connections.

Steps to Reproduce

1. Paste the model below in the AADL text editor.
2. Notice that there are no errors
3. Change the feature connection in line 12 to a port connection
4. The connection is now marked with an error

package P1
public

    system S
    end S;

    system implementation S.i
        subcomponents
            a1: abstract A;
            b: abstract B;
        connections
            c1: feature a1.aout -> b.bin;
    end S.i;

    abstract A
        features
            aout: out data port D1;
    end A;

    abstract B
        features
            bin: in data port D2;
    end B;

    data D1
    end D1;

    data D2
    end D2;

end P1;

Environment

• OSATE Version: 2.7.1
• Operating System: all

[lwrage]

The AADL standard does not require any validation. However, it makes sense to add more validations depending on the source and destination features. OSATE does this already if source and destination are feature groups.

[lwrage]

There are plenty of edge cases that could be handled. For now validate as port connection if both ends are port connection ends.

[lwrage]

see also saeaadl/aadlv2.2#61