search

osate / osate2

Open Source AADL2 Tool Environment
http://osate.org
Eclipse Public License 2.0
39 stars 8 forks source link

Request - API to retrieve NamedElement by qualified name #242

Closed philip-alldredge closed 11 years ago

philip-alldredge commented 11 years ago

After looking in EMFIndexRetrieval, there does not appear to be a method that will return a NamedElement given a qualified name. It appears most of the methods in EMFIndexRetrieval requires prior knowledge of the type and is restricted to packages and components.

Requested feature: A method that would accept a qualified name as a string and return the appropriate NamedElement. I believe such a method would be useful in cases where plugins need to reference AADL model elements by qualified name and retrieve them to perform processing.

juli1 commented 11 years ago

Such a method would fit into Aadl2Util. Do you want to propose a patch to address the issue because I am assuming you would need such as code snippet for your plugins ? If not, it would be helpful if you can provide a code sample that would use this method so that we can have an idea about what you expect.

philip-alldredge commented 11 years ago

I don't have a patch as of right now. I have a temporary work around. I'm looking at other alternatives at the moment. If you would like, we can close the issue and I can reopen it when I have a patch or a concrete example.

philip-alldredge commented 11 years ago

I have created a patch that adds the desired method as well as a cleanup of an existing method. I have created a gist of the patch. The link is below. In the future, what is the best way to submit the patch. The wiki page: https://wiki.sei.cmu.edu/aadl/index.php/Submitting_a_patch describes creating the patches, but not where to send them.

https://gist.github.com/philip-alldredge/a866a6c9c83c205734e9

juli1 commented 11 years ago

Dear Philip, You did it just ... right ! Your patch is applied, thanks for yoru contribution !