osate / osate2

Open Source AADL2 Tool Environment
http://osate.org
Eclipse Public License 2.0
36 stars 8 forks source link

Missing error/warning markers on instance model elements #2612

Closed lwrage closed 3 years ago

lwrage commented 3 years ago

Summary Instance editor and AADL navigator no longer show any error or warning markers on instance objects.

This used to work in OSATE 2.9.0.

Steps To Reproduce

  1. Add model below in an AADL project
  2. Instantiate S.i
  3. Open instance model in instance editor
  4. Expand instance model in navigator
package Issue2612
public

    system S
    end S;

    system implementation S.i
        subcomponents
            l: system L;
            m: system M.i;
            r: system R;
        connections
            lm: feature l.o -> m.i;
            mr: feature m.o -> r.i;
        flows
            ee: end to end flow l.src -> lm -> m.pth -> mr -> r.snk;
    end S.i;

    system L
        features
            o: out feature;
        flows
            src: flow source o;
    end L;

    system M
        features
            i: in feature;
            o: out feature;
        flows
            pth: flow path i -> o;
    end M;

    system implementation M.i
        subcomponents
            mm: system M;
        connections
            imm: feature i -> mm.i;
    end M.i;

    system R
        features
            i: in feature;
        flows
            snk: flow sink i;
    end R;

end Issue2612;

Screenshots OSATE 2.9.1: image

OSATE 2.9.0: image

Desktop (please complete the following information):

Additional context Maybe caused by the fix to #2430.

AaronGreenhouse commented 3 years ago

Same problem as Issue #2609. Fix for 2609 fixes this too.

lwrage commented 3 years ago

Only navigator markers are #2609. Missing markers in the instance editor are the main issue. This is caused by switching back to the EMF generated model editor which doesn't have that functionality.