osate / osate2

Open Source AADL2 Tool Environment
http://osate.org
Eclipse Public License 2.0
39 stars 8 forks source link

Unable to Instantiate System/Qualified names are not unique #270

Closed philip-alldredge closed 11 years ago

philip-alldredge commented 11 years ago

When using the AADL model below, I am unable to instantiate A.test. OSATE tells me to selectea system implementation and that I have a feature selected. I believe the root cause is that both the feature test in feature System and the system implementation A.test both have the same qualified name.

package conflict
public
    system A
    features
        test: feature;      
    end A;

    system implementation A.test
    end A.test;

end conflict;
reteprelief commented 11 years ago

Interesting. The error only occurs when you invoke instantiate from the outline view. When doing it within the text it works fine.

Will look into it.

From: philip-alldredge [mailto:notifications@github.com] Sent: Thursday, August 08, 2013 11:15 AM To: osate/osate2-core Subject: [osate2-core] Unable to Instantiate System/Qualified names are not unique (#270)

When using the AADL model below, I am unable to instantiate A.test. OSATE tells me to selectea system implementation and that I have a feature selected. I believe the root cause is that both the feature test in feature System and the system implementation A.test both have the same qualified name.

package conflict

public

system A

features

    test: feature;

end A;

system implementation A.test

end A.test;

end conflict;

— Reply to this email directly or view it on GitHubhttps://github.com/osate/osate2-core/issues/270.

juli1 commented 11 years ago

The difference comes from the fact that the outline menu is provided by xtext and the text function call directly the instantiation code. There are some additional checks done in Xtext that check uniqueness of some identifiers.

juli1 commented 11 years ago

Fixed !