osate / osate2

Open Source AADL2 Tool Environment
http://osate.org
Eclipse Public License 2.0
36 stars 8 forks source link

Issues Integrating with the AADL Properties View #330

Closed philip-alldredge closed 10 years ago

philip-alldredge commented 10 years ago

I am having a couple issues integrating my plugin with the current AADL Property Views. I have developed patches that resolve the issue. They are located at https://gist.github.com/philip-alldredge/30110278f09bf1ec5237

propertyview_holder_lookup.patch modifies the AADL property view so that it will use the XText document if provided to lookup the selected element. This is needed because it allows the AADL property view to be used in cases where the resource has not been saved. This effects not only my plugin but also general usage of the viewer: An exception is thrown if the user attempts to add a property association to a newly entered element using the view before saving the file.

propertyview_update.patch modifies the AADL property view so that it only uses the resource set provided by Xtext when the selection has an associated XText document. This is needed because otherwise the view can enter an invalid state so that it is no longer capable of viewing values if the Xtext editor is no longer open.

juli1 commented 10 years ago

Applied.