search

osate / osate2

Open Source AADL2 Tool Environment
http://osate.org
Eclipse Public License 2.0
36 stars 8 forks source link

InstanceReferenceValue object replaced by ReferenceValue object in instance model #462

Closed Etienne13 closed 10 years ago

Etienne13 commented 10 years ago

Hi,

when instantiation one example from osage repository (example: https://github.com/osate/examples/blob/master/display-manager/initial-model, system to instantiate is display_manager.i in file integration.aadl), the instance model contains a list of ReferenceValue object for the Actual_Processor_Binding property association while it used to contain a list of InstanceReferenceValue object.

I guess this is a regression.

Best regards, Etienne.

juli1 commented 10 years ago

Not sure but seems to be related to commit fce7f3efe756f2c4a44173a08b2eafd66f9359d5 Previous version works correctly.

lwrage commented 10 years ago

@juli1 Did you confirm that fce7f3efe756f2c4a44173a08b2eafd66f9359d5 does not work?

lwrage commented 10 years ago

The example uses a property set pok, which is missing from the project so I can't reproduce the issue. Can you add it, please?

lwrage commented 10 years ago

Never mind, I see that pok is used in just one place.

Etienne13 commented 10 years ago

Yes, you can reproduce the issue without this property. On my end I am updating my plugin to remove this dependency to the pok property set.

lwrage commented 10 years ago

The problem is caused by a metamodel change. I'll fix it later today.

lwrage commented 10 years ago

Fixed with 22c924bd0aa095ccba18034f972e37191f635f84