osate / osate2

Open Source AADL2 Tool Environment
http://osate.org
Eclipse Public License 2.0
36 stars 8 forks source link

Parameter connection validation incorrect #616

Closed Korny666 closed 9 years ago

Korny666 commented 9 years ago

package connection_bug
public
    with Base_Types;

    thread Test
        features
            setterAndGetter: feature group setGet;
    end Test;

    thread implementation Test.impl
        subcomponents
            Counter: data Base_Types::Integer;
        connections
            set: parameter setterAndGetter.setValue -> Counter;
            return: parameter Counter -> setterAndGetter.setValue;
    end Test.impl;

    feature group setGet
        features
            setValue: in data port Base_Types::Integer;
            getValue: out data port Base_Types::Integer;
    end setGet;
end connection_bug;

The connections set and return are not visible.

bug

lwrage commented 9 years ago

The AADL model is not valid. According to the 9.3 (L2) the parameter connection must have a call parameter as its destination (source) if the source (destination) is a thread port.

lwrage commented 9 years ago

@philip-alldredge Should the graphical editor show invalid connections?

philip-alldredge commented 9 years ago

I'm out of the office this week but I'll take a look when I return. Typically the graphical editor will show invalid connections when possible.

philip-alldredge commented 9 years ago

There was a bug affecting connections involving features inside of feature groups. I just pushed a fixed to the graphical editor. However, the listed model will not display as expected because the use of set as the connection name. set is a reserved word in AADL.

Please report any additional issues with the graphical capability directly to the graphical editor project. This ensures that it will be seen by the developers working on that project.https://github.com/osate/osate-ge/issues