osate / osate2

Open Source AADL2 Tool Environment
http://osate.org
Eclipse Public License 2.0
39 stars 8 forks source link

Local path in target definition #7

Closed jftilman closed 11 years ago

jftilman commented 13 years ago

The current target definition for Indigo Eclipse platform (org.osate.build.target/indigo.target) contains a local path

Thus, it can not be loaded when the sources are checked out on another computer. If this item is really needed and can not be found on an update site, I suggest the following changes:

1° Replace the full absolute path by an environment variable that refers to a directory containing the local target platforms (e.g., OSATE_TARGETS):

path="${env_var:OSATE_TARGETS}/platform-3.7"

Thus, the developer can set this environment variable as he want.

2° We also need to have the contents of this local target platform elements. A new (pseudo-)Eclipse project could contain it. The developer has just to checkout this project somewhere and set the environment variable accordingly.

jftilman commented 13 years ago

It seems that the local item in the target definition can be just removed without any consequence on the build.

osate commented 13 years ago

The platform is needed to build for a different target architecture, e.g., build a win32 version on linux. The platform must be downloaded from eclipse.org.

jftilman commented 13 years ago

The problem with the current target definition is that it can not be resolved automatically for the lambda user who want to build and use Osate on his own platform. A solution might consist in defining a second target definition for these specific cross-platform issues.

juli1 commented 11 years ago

Hi Jean-Francois,

Is it possible to send us a patch regarding this issue ? Because we do not experience such problems, we need a way to identify the issue itself (why this is a problem) or a patch that addresses the problem directly.

Thanks,

jftilman commented 11 years ago

Hi Julien,

The problem is simple: the target definitions contain references on local files. Then, they can not be resolved. All the references should refer to plug-ins that are available through public update sites. When you set such a target definition as target platform, you are no more able to build Osate.

The interest of a target definition is to ensure that all the builds will be done with the same environment, even if everybody updates his own eclipse platform with particular and different components. For example, it should provide the xtext component, that is not preinstalled in the "Eclipse modeling tool" bundle we recommend to use in the wiki page (https://wiki.sei.cmu.edu/aadl/index.php/Getting_Osate_2_sources#Getting_the_Eclipse_and_XText_environment). (I have added a line to indicate that XText SDK shall be installed also).

Best regards... and happy new year!

juli1 commented 11 years ago

Hi,

We recently upgraded to Juno and added a new target platform. You can download the necessary zip file here : http://download.eclipse.org/eclipse/downloads/drops4/R-4.2-201206081400/index.php#EclipseSDK and on http://www.eclipse.org/downloads/download.php?file=/eclipse/downloads/drops4/R-4.2-201206081400/org.eclipse.platform-4.2.zip

We use this target file for building our internal release. However, it references files in /tmp because we do not want to include the big zip files. Instead, just download the file and either put it in /tmp or change the file reference in the target platform file.

Please let me know if it solves your issues,

Best,

jftilman commented 11 years ago

Hi,

I am not convinced by this approach. This target definition is either a file for your internal need, or it is for the use of any people who get the Osate sources.

I expect this will help. Best regards.

jftilman commented 11 years ago

Argh. My source excerpt has disappeared. I past it again:

< location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit"> < unit id="org.eclipse.platform.ide" version="4.2.1.M20120914-1800"/> < repository location="http://download.eclipse.org/eclipse/updates/4.2"/> < /location>

juli1 commented 11 years ago

Hi Jean-Francois,

In that case, would it be possible to make some suggestion for improvements ? Submitting/proposing a patch would be a good idea.

jftilman commented 11 years ago

????

I have just provided you a suggestion! : Add the 4 lines I gave before in the "juno.target" and remove the line

< repository location="jar:file:/tmp/org.eclipse.platform-4.2.zip!/"/>

Is is clear?

juli1 commented 11 years ago

Thanks for your comment. Also, it was not clear if we shall keep the reference to the zip or not. Thanks.

juli1 commented 11 years ago

Hi, I apply the changes you proposed and I got errors in Eclipse. Please send a file or a patch to avoid any confusing proposal and make sure we implement what you suggest.

Thanks,

jftilman commented 11 years ago

Le 03/01/2013 20:28, Julien a écrit :

Hi, I apply the changes you proposed and I got errors in Eclipse. Please send a file or a patch to avoid any confusing proposal and make sure we implement what you suggest.

Hi,

this is the file I used to compile successfully the code. Be sure to wait for the complete resolution of the target definition before setting it as the target platform. Best regards.

 Jean-François

Jean-François Tilman tel : +33 9 72 28 55 72 Jean-Francois.Tilman@geensyde.fr mob : +33 6 86 93 53 10 Geensyde adr : 7 rue Jean Mermoz http://www.geensyde.fr 78000 Versailles

juli1 commented 11 years ago

Hello, Can you submit the file ? Either by gist (https://gist.github.com/), dropbox or by private e-mail ? Thanks.

jftilman commented 11 years ago

Aïe. The joined file seems have been filtered. I have resent it to your personal email address.

JFT

juli1 commented 11 years ago

Fixed in latest commit.