search

osate / osate2

Open Source AADL2 Tool Environment
http://osate.org
Eclipse Public License 2.0
36 stars 8 forks source link

Flow Implementation not handled in unparsing from AadlUnparser. #79

Closed mnam closed 12 years ago

mnam commented 12 years ago

I'm not sure if this is just not implemented yet.

First, I see that when I generate an aaxl2 file to check, I don't see any of the flow implementation show up. Only the Flow Specifications show. Not sure that this was intended.

Since, I currently can't unparse the aaxl2 file to check if it deletes my flow implementations because of reasons that I explained in the previous ticket, I still have strong reasons to believe that the unparsing of flow implementations are not being done.

My tool would generate some flow implementations and unparse it and reinstantiate. While the updated instance file gives end to end flow instances with the changes applied, the unparsed aadl file is missing the flow implementation part.

Thanks. Sincerely, Min Young Nam

reteprelief commented 12 years ago

Hi Min Young,

I did some testing on my side. The flow implementation is in the aaxl2 file. Looking at the unparser I found out that it skips the generation of flow implementations. Will work on it.

mnam commented 12 years ago

Hi Peter,

Oh so I didn't check the generated aaxl2 file by a text editor. I see it now. Is the flow implementation not shown by the Instance Model Editor because of similar reasons that it is not parsed?

Thanks. Min Young

From: Peter Feiler [reply@reply.github.com] Sent: Friday, July 27, 2012 3:27 PM To: Nam, Min Young Subject: Re: [osate2-core] Flow Implementation not handled in unparsing from AadlUnparser. (#79)

Hi Min Young,

I did some testing on my side. The flow implementation is in the aaxl2 file. Looking at the unparser I found out that it skips the generation of flow implementations. Will work on it.

Reply to this email directly or view it on GitHub: https://github.com/osate/osate2-core/issues/79#issuecomment-7315354

reteprelief commented 12 years ago

fixed the unparser and pushed it up. I will submit a separate issue report regarding the Instance Model Editor not showing the content of declarative models correctly.

mnam commented 12 years ago

Thanks Peter,

Although it may not be due to this issue, after a new pull from the repository, I'm getting errors in the SerializeHandler because it is importing packages of org.osate.xtext.aadl2.errormodel.* which I can't find anywhere in the develop or the master branch. Could it be something you are working on that is not submitted? It was okay for me to comment these because I saw that their usage was all commented. Also for similar reasons, in the MANIFEST.MF file of the org.osate.xtext.aadl2.ui in required plug-ins we get an error for org.osate.xtest.aadl2.errormodel.

Sincerely, Min Young

From: Peter Feiler [reply@reply.github.com] Sent: Saturday, July 28, 2012 5:51 AM To: Nam, Min Young Subject: Re: [osate2-core] Flow Implementation not handled in unparsing from AadlUnparser. (#79)

fixed the unparser and pushed it up. I will submit a separate issue report regarding the Instance Model Editor not showing the content of declarative models correctly.

Reply to this email directly or view it on GitHub: https://github.com/osate/osate2-core/issues/79#issuecomment-7332127

mnam commented 12 years ago

Hi Peter,

I found a bug in the unparsing of the flow implementation. Investigated it because it wasn't working correctly for me.

In line 1471 of AadlUnparser

FlowEnd outend = fps.getInEnd();

I believe this should be getOutEnd(); and then it works for me.

Thanks. Min Young

From: Peter Feiler [reply@reply.github.com] Sent: Saturday, July 28, 2012 5:51 AM To: Nam, Min Young Subject: Re: [osate2-core] Flow Implementation not handled in unparsing from AadlUnparser. (#79)

fixed the unparser and pushed it up. I will submit a separate issue report regarding the Instance Model Editor not showing the content of declarative models correctly.

Reply to this email directly or view it on GitHub: https://github.com/osate/osate2-core/issues/79#issuecomment-7332127

reteprelief commented 12 years ago

Was a mistake of mine from a debugging session of the new error annex. Have it removed.

Peter

-----Original Message----- From: mnam [mailto:reply@reply.github.com] Sent: Saturday, July 28, 2012 12:44 PM To: Peter Feiler Subject: Re: [osate2-core] Flow Implementation not handled in unparsing from AadlUnparser. (#79)

Thanks Peter,

Although it may not be due to this issue, after a new pull from the repository, I'm getting errors in the SerializeHandler because it is importing packages of org.osate.xtext.aadl2.errormodel.* which I can't find anywhere in the develop or the master branch. Could it be something you are working on that is not submitted? It was okay for me to comment these because I saw that their usage was all commented. Also for similar reasons, in the MANIFEST.MF file of the org.osate.xtext.aadl2.ui in required plug-ins we get an error for org.osate.xtest.aadl2.errormodel.

Sincerely, Min Young

From: Peter Feiler [reply@reply.github.com] Sent: Saturday, July 28, 2012 5:51 AM To: Nam, Min Young Subject: Re: [osate2-core] Flow Implementation not handled in unparsing from AadlUnparser. (#79)

fixed the unparser and pushed it up. I will submit a separate issue report regarding the Instance Model Editor not showing the content of declarative models correctly.

Reply to this email directly or view it on GitHub: https://github.com/osate/osate2-core/issues/79#issuecomment-7332127

Reply to this email directly or view it on GitHub: https://github.com/osate/osate2-core/issues/79#issuecomment-7334528