Archived Server - server manually set to archived status is not picked up by archive auditor

[osbornm]

h2. Steps to reproduce

This occurred in production. a user attempted to archive a group of 20 servers. All succeeded except the last 3. the issue was fixed and the bp resumed. due to another bug, all the previously successfully archived servers were reset to queued for archive. once the BP completed, we had to manually set the server status to Archived using the hardware page. but when this was done, the archive auditor did not pick up these servers and populate the archived space value in the hardware table

From Darren:

I figured out what�s going on with the Archive audits for those GB1 AVSP Servers. I think it�s pretty easy fix.

It boils down to this code in the GroupedHardwareServiceProvider.UpdateHardware method:

var canUpdateHardwareForGroup = hg.StatusID == (int) HardwareStatusEnum.Active || (hg.StatusID == (int) HardwareStatusEnum.Archived && request.Hardware.HardwareStatus == HardwareStatusEnum.QueuedForDelete);

if (Guard.FailsValidationCheck(response, canUpdateHardwareForGroup, "Hardware group has been deleted.")) return response;

Since both the Group and Server are marked as Archived, the error returned is that the hardware group has been deleted. Like I said this should be an easy fix.

Created From: https://agilezen.com/project/48813/story/38

[osbornm]

Luke Bakken (11/27/2012) : The validation check that Darren refers to was removed in this commit:

Author: caledh cale.hoopes@tier3.com Date: 2 weeks ago (Fri Nov 09 15:49:26 2012) Commit hash: 55932cab83e4d9cd4fa8eb2952d3ea958af42fca Parent(s): 4858953987

Removing validation check regarding archived groups when updating hardware.

Contained in branches: Feature-CrossDC-Firewall, Feature-CrossDC-Firewall-TryMe, SWAT-ProdHotFix, UI-Convert-BP-Deploy, feature-FirewallAsync, feature-WebFabricMonitoring, fix-ECPFoundationAddInnerExceptionToLogFile, master Contained in no tag

[osbornm]

Thomas Quigley (12/5/2012) : apparently the archive auditor is not working in QA (possibly).

Will have to verify this in production.

[osbornm]

Matt Weller (1/10/2013) : Doubled checked Luke's comment and it looks good. I will check with Magnum as to if we can only verify in production.

[osbornm]

Thomas Quigley (1/10/2013) : I am going to validate in production

[osbornm]

Thomas Quigley (1/29/2013) : attempted to test in production by marking an active server as Archived and waiting for archive auditor to run. However, the Archived Disk Space value was never updated. Checking with Darren to see if there is something else that needs to be set.

[osbornm]

Thomas Quigley (1/29/2013) : I attempted to verify this in DE1.

1. set status to Archived on active server. no update to archived disk space
2. archived a server successfully. then changed archived disk space to 0. no update to archived disk space.

verified the auditor had run, and ran manually just in case, but no updates made.

I believe this is an issue with the auditor, as the space value is updated correctly when an archive is completed, but doesn't seem to be updating after the fact if values change.