search

osbuild / bootc-image-builder

A container for deploying bootable container images.
https://osbuild.org
Apache License 2.0
87 stars 46 forks source link

support s390x #460

Open cgwalters opened 1 month ago

cgwalters commented 1 month ago

Copying the bits from here https://github.com/containers/bootc/issues/569 related to bib

It'd also be really great here to figure out how to share code w/Anaconda I'd say.

achilleas-k commented 1 month ago

What code would we share with Anaconda for this? Are we planning on building ISOs for s390x?

yoheiueda commented 2 weeks ago

@cgwalters I raised a PR https://github.com/osbuild/images/pull/758 for this issue.

We can add a partition table for s390x after the PR gets merged.

https://github.com/osbuild/bootc-image-builder/blob/61863ff3c39da79716b0a94945b153e58a138ca6/bib/cmd/bootc-image-builder/partition_tables.go#L24-L121

yoheiueda commented 1 week ago

@cgwalters @mvo5 @achilleas-k

I raised a PR https://github.com/osbuild/bootc-image-builder/pull/515 to include the latest images library that includes the fix for the issue reported above.

This PR also updates the setting for golangci-lint CI test to suppress a false-positive lint error.