osbuild / image-builder-frontend

Image Builder service for console.redhat.com
Apache License 2.0
20 stars 53 forks source link

Wizard CSS tweaks #1030

Open lucasgarfield opened 1 year ago

lucasgarfield commented 1 year ago
          Ah, that's right. I need to revisit how I did the layout on the sources step as I think I might have been relying on this as well... even if it turns out to be fine, I think that this is a good sign that we should avoid these global width changes when they are needed for specific components... Let's see if we can find a good inline solution so we can eliminate these global overrides.

_Originally posted by @lucasgarfield in https://github.com/RedHatInsights/image-builder-frontend/pull/1001#discussion_r1141997172_

lucasgarfield commented 1 year ago

We need to inline the CSS overrides we currently have in the Wizard for .pf-u-min-width and .pf-u-max width. These are being used to adjust widths in the review step and sources step, respectively. It is hard to keep track of what they are actually needed for and we may eventually have a collision between steps.