search

osbuild / image-builder-frontend

Image Builder service for console.redhat.com
Apache License 2.0
18 stars 52 forks source link

Disable navigation on the left #1616

Open regexowl opened 7 months ago

regexowl commented 7 months ago

When user clicks to the Review step and then jumps back to another step the Wizard currently allows to change values and directly jump back to the Review step, evading possible disabled buttons. This can end up in this for example

image

How to reproduce:

  1. click through the Wizard to the Review step
  2. click on "Amazon Web Services" in the navigation on the left
  3. choose one of the radios, but don't fill in any values - the Next button should be disabled
  4. click on the "Review" in the navigation on the left and jump to the Review step anyway
ezr-ondrej commented 2 months ago

IMO this would be fixed with using the new validation, we would highlight errors on the step and disable creating the image. User can freely jump around the wizard if they wish to, but will always know what's wrong.

regexowl commented 2 months ago

Yup, agree! The navigation would stay enabled, but errors would be clear and blueprint creation disabled. Sounds good to me!