search

osbuild / images

Image builder image definition library
Apache License 2.0
23 stars 52 forks source link

disk: define PartitionTableType enum for partition table types (COMPOSER-2355) #1004

Closed achilleas-k closed 1 week ago

achilleas-k commented 2 weeks ago

This is part of #926 which I'm slowly splitting into smaller, bite-sized PRs.

Add a new enum, PartitionTableType, for referring to the two partition table types, "dos" and "gpt". This is currently not used but will be part of the new custom partition table generator.

achilleas-k commented 2 weeks ago

Needs to be rebased on #1002.

achilleas-k commented 2 weeks ago

I know you will laugh at me but I would fove a tiny test but otherwise this is fine.

No no, it's my fault. I should have known and done it already.

achilleas-k commented 2 weeks ago

I know you will laugh at me but I would fove a tiny test but otherwise this is fine.

Added TWO!

achilleas-k commented 2 weeks ago

Merging this because I'm going to need it for #1009.

achilleas-k commented 1 week ago

Merging this because I'm going to need it for #1009.

Actually didn't end up depending. I was thinking of using the new enums in the PartitionTable but it's a bigger change that I'd rather do in a separate PR.