search

osbuild / manifest-db

Stores all the manifests and corresponding image-infos to test osbuild.
Apache License 2.0
0 stars 8 forks source link

Check unbuildable manifests with osbuild --inspect #61

Open achilleas-k opened 2 years ago

achilleas-k commented 2 years ago

Some manifests can't be built because they need to download sources that aren't available. In particular, ostree-based image types that rely on pulling an existing commit, like the edge/iot-installer and edge/iot-raw-image types, need to pull an ostree commit to embed it in an installer or raw image. For this, we just generate manifests with fake values for the ostree source so that we have a test manifest for change detection alone.

While these can't be built, they can be verified to be correct, using osbuild --inspect and checked for errors.

NB: With the current manifests, these will fail because of the parent commit ID being malformed in our test manifests, but that's a small issue to fix.

lavocatt commented 2 years ago

Thanks for bringing this issue. I believe these are caught by the osbulid-image-tests command as manifest validation failed right ?

So if I understand it correctly, we could have a special treatment for them ? by just verify them with osbuild --inspect

Let me propose an alternative: We could keep an ostree commit on S3, always reference it in the DB, and add a prerequisite for these manifests to have the file accessible on disk.

What do you think ?