search

osbuild / osbuild-composer

An HTTP service for building bootable OS images.
https://www.osbuild.org
Apache License 2.0
156 stars 107 forks source link

Use Go 1.21 and update osbuild/images to v0.69.0 #4241

Closed achilleas-k closed 2 weeks ago

achilleas-k commented 2 weeks ago

go.mod: update to go v1.21

Go 1.21 is included in all currently supported distro versions. It is required by new updates to some of our dependencies, including osbuild/images.

go.mod: update osbuild/images to v0.69.0

weldr: update expected error messages

Some depsolve-related error messages in osbuild/images changed. Update the expected error messages in our tests.

achilleas-k commented 2 weeks ago

Tests failing with

✔️ Instance checking
Warning: Permanently added '129.213.58.207' (ECDSA) to the list of known hosts.
postgresql-10.23-4.module+el8.9.0+21317+d2c6bf8a.x86_64
dummy-1.0.0-0.noarch
System is subscribed.
Unregistering from: subscription.rhsm.redhat.com:443/subscription
System has been unregistered.
✔️ Checking custom directories and files
✔️ Checking custom repositories
✔️ Checking OpenSCAP customizations
cat: /usr/share/xml/osbuild-openscap-data/tailoring.xml: No such file or directory

@kingsleyzissou Is this related to recent oscap changes in osbuild/images? Either v0.68.0 or v0.69.0?

kingsleyzissou commented 2 weeks ago

Tests failing with

✔️ Instance checking
Warning: Permanently added '129.213.58.207' (ECDSA) to the list of known hosts.
postgresql-10.23-4.module+el8.9.0+21317+d2c6bf8a.x86_64
dummy-1.0.0-0.noarch
System is subscribed.
Unregistering from: subscription.rhsm.redhat.com:443/subscription
System has been unregistered.
✔️ Checking custom directories and files
✔️ Checking custom repositories
✔️ Checking OpenSCAP customizations
cat: /usr/share/xml/osbuild-openscap-data/tailoring.xml: No such file or directory

@kingsleyzissou Is this related to recent oscap changes in osbuild/images? Either v0.68.0 or v0.69.0?

Yeah, I fixed the test (in images), but we moved the tailoring file to /oscap_data since all the osbuild stage saves all the artifacts there.

Edit: had to check which repo we were in, thought this was for images.

achilleas-k commented 2 weeks ago

Yeah, I fixed the test (in images), but we moved the tailoring file to /oscap_data since all the osbuild stage saves all the artifacts there.

So is it enough to update the path in the test to look for the file in /oscap_data? Just confirming before I start the CI runs again.

kingsleyzissou commented 2 weeks ago

Yeah, I fixed the test (in images), but we moved the tailoring file to /oscap_data since all the osbuild stage saves all the artifacts there.

So is it enough to update the path in the test to look for the file in /oscap_data? Just confirming before I start the CI runs again.

Yeah, as far as I can see we aren't running any scans. So changing it to /oscap_data/tailoring.xml should be enough. Here is the commit from images: https://github.com/osbuild/images/commit/7bd70d828ee7dc066a4c529cb2b8eb8f39ef0a06