tests: fix api.sh gcp ssh connection timeout

osbuild / osbuild-composer

An HTTP service for building bootable OS images.

https://www.osbuild.org

Apache License 2.0

160 stars 108 forks source link

tests: fix api.sh gcp ssh connection timeout #4348

Closed jrusz closed 2 weeks ago

jrusz commented 1 month ago

This pull request includes:

[ ] adequate testing for the new functionality or fixed issue
[ ] adequate documentation informing people about the change such as
- [ ] submit a PR for the READMEs listed here
- [ ] submit a PR for the osbuild.org website repository if this PR changed any behavior not covered by the automatically updated READMEs

bcl commented 3 weeks ago

Can you just pass it after the --? Otherwise I think you need to escape the "s in order to get them to pass to the command instead of being evaluated by bash.

jrusz commented 3 weeks ago

Can you just pass it after the --? Otherwise I think you need to escape the "s in order to get them to pass to the command instead of being evaluated by bash.

I've been trying different variations over the week while working on other stuff and I've finally found something that seems to work :sweat_smile:

jrusz commented 3 weeks ago

Unfortunately it looks like it doesn't help resolve our issue https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/7807093869 I'm going to try something else.

jrusz commented 3 weeks ago

I was unable to come into agreement with the gcloud command so I've decided to implement our own retry mechanism which worked when I tested it on the side, I hope other tests are fine with it as well. Here is where it helped prevent the timeout https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/7809695856