search

osbuild / osbuild.github.io

Sources of the osbuild.org website
https://osbuild.org
Apache License 2.0
1 stars 15 forks source link

ghactions: Protect generated dev-guide from changes #46

Closed ochosi closed 7 months ago

ochosi commented 7 months ago

Test whether a pull request introduces changes in one of the files that get pulled in automatically on a schedule.

This breaks the previous workflow of adding in the new readmes when they get added to the readme-list file (see e.g. https://github.com/osbuild/osbuild.github.io/pull/40/files). That workflow was nice because it allowed the reviewer to see the changes ahead of time. OTOH it prevents pull requests like this one: https://github.com/osbuild/osbuild.github.io/pull/43

ondrejbudai commented 7 months ago

(well, except that it doesn't work :sweat_smile: )

Maybe diff ${branch}..origin/main? We might even simplify this to HEAD..origin/main I think.

ochosi commented 7 months ago

(well, except that it doesn't work 😅 )

Maybe diff ${branch}..origin/main? We might even simplify this to HEAD..origin/main I think.

I tried HEAD initially but forgot that ofc the origin/ is part of the ref if the branch has never been checked out...