Open croissanne opened 2 years ago
Discussed this with @gicmo and @achilleas-k, these are some findings:
GET
requests to S3 buckets to fail with 500.
GET
requests, so the likelihood of at least one failing is significant.@cgwalters have we missed anything here? Any thoughts on how to mitigate the problem?
I think we would need to translate 5xx
in _ostree_fetcher_http_status_code_to_io_error
to something we can match in _ostree_fetcher_should_retry_request
.
I don't see any related change in stages/org.osbuild.ostree.pull
@croissanne is it still something to fix ?
Yes, but ideally we could offload this to ostree itself. https://github.com/ostreedev/ostree/pull/1847 existed, but is closed now. I want to avoid having to retry the entire stage/pull, only fetching the individual files should be retried.
I'm gonna write a proposal for a fix and we can discuss it in the PR when it's there.
Some errors we're seeing in the service when putting the object in aws s3. But unsure if we want retry logic in osbuild, or if it's better that alternative storage solutions are tried.