search

osbuild / otk

A proof of concept for a new `osbuild-mpp`.
https://osbuild.org/
Apache License 2.0
4 stars 9 forks source link

example/centos: deduplication of package sets #261

Closed supakeen closed 1 month ago

supakeen commented 1 month ago

This PR has ongoing work in deduplicating and sharing things regarding package sets. It is draft because more can/should be done.

supakeen commented 1 month ago

There isn't much more to be gained in this PR regarding +/- lines. I'm already on the fence on further deduplication. Let's merge it as is (?) and followup with more as it makes sense.

supakeen commented 1 month ago

Needs rebase after I land the rename-externals-PR here.

supakeen commented 1 month ago

@mvo5 Agreed on the rename of _include.yaml. I'll call them common. My initial thinking was that _ prefixed files should never be included directly :)

supakeen commented 1 month ago

As for the sharing of more things, yes I think that's a good idea for a followup, I consider this one to be a starting point for more deduplication as we see fit.

Perhaps even after we reconsider (some of) the package sets as they currently live in images.

mvo5 commented 1 month ago

@mvo5 Agreed on the rename of _include.yaml. I'll call them common. My initial thinking was that _ prefixed files should never be included directly :)

I don't mind _common.yaml, no strong opinion here.

supakeen commented 1 month ago

Updated name to common.yaml; rebased on now-working-tests after the rename :)