search

oscafrica / design

🎨 Everything Design related in OSCA
28 stars 13 forks source link

Home page & interactions_Tab #19

Closed perriefidelis closed 3 years ago

perriefidelis commented 4 years ago

Tab view for issues #3

The tab view should be in sizes - 834px and 768px frames(artboards). See design system on #1

AAjiro1 commented 4 years ago

interested and working on it.... Here https://www.figma.com/file/30RarYRZWEyvtNSg1uebC3/Osca

perriefidelis commented 4 years ago

@AAjiro1 I did drop a couple of comments... Please see our style guide

perriefidelis commented 4 years ago

@all-contributors please add @AAjiro1 for design

allcontributors[bot] commented 4 years ago

@perriefidelis

I've put up a pull request to add @AAjiro1! :tada:

perriefidelis commented 4 years ago

I also feel it will be great if we also design for 768px

AAjiro1 commented 4 years ago

Made the corrections, you can check it out @perriefidelis
https://www.figma.com/file/30RarYRZWEyvtNSg1uebC3/Osca?node-id=1%3A147

perriefidelis commented 4 years ago

It's looking good @AAjiro1 ... The spacing between the text elements and the arrow icon, can you make it uniform with other screen sizes?

AAjiro1 commented 4 years ago

adjusted @perriefidelis

perriefidelis commented 4 years ago

We're almost there yayy 🚀... one more thing I think is left is the horizontal spacing, please review that

AAjiro1 commented 4 years ago

done, ready for review @perriefidelis

perriefidelis commented 4 years ago

01_Home_Default_Tablet 768px 02_Home_Default_Tablet 834px