search

oscal-compass / compliance-trestle

An opinionated tooling platform for managing compliance as code, using continuous integration and NIST's OSCAL standard.
https://oscal-compass.github.io/compliance-trestle
Apache License 2.0
161 stars 62 forks source link

Existing task test cases should be OSCAL version agnostic #1275

Open degenaro opened 1 year ago

degenaro commented 1 year ago

Describe the bug

Some task test cases do a file compare of generated OSCAL document with a pre-generated one, and will fail when OSCAL version changes since OSCAL version is embedded in the docs.

To Reproduce

Mock trestle code with a new version of OSCAL.

Expected behavior

The task test cases should not fail when OSCAL version changes.

Screenshots / Logs.

N/A

Environment

Nominal trestle install.

fsuits commented 1 year ago

Thanks @degenaro - yes ideally the tests would be resilient to changes in the oscal version as specified in trestle/oscal/__init__.py

jpower432 commented 1 month ago

@vikas-agarwal76 @degenaro To confirm, will this need to be broken down into multiple issues or can we convert this to an enhancement or bug?

degenaro commented 1 month ago

I think one issue is sufficient. There are perhaps 12-20 test cases that need a line or two deleted, and perhaps one new test case (if there isn't one already) dedicated to checking the OSCAL version.

I'd call it an enhancement, since nothing is really wrong.

On Mon, Aug 19, 2024 at 10:50 AM Jennifer Power @.***> wrote:

@vikas-agarwal76 https://github.com/vikas-agarwal76 @degenaro https://github.com/degenaro To confirm, will this need to be broken down into multiple issues or can we convert this to an enhancement or bug?

— Reply to this email directly, view it on GitHub https://github.com/oscal-compass/compliance-trestle/issues/1275#issuecomment-2296768561, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD66XM366B6MFJOPK34WNLZSIA3FAVCNFSM6AAAAABMX7ZSD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJWG43DQNJWGE . You are receiving this because you were mentioned.Message ID: @.***>