oscal-compass / compliance-trestle

An opinionated tooling platform for managing compliance as code, using continuous integration and NIST's OSCAL standard.

https://oscal-compass.github.io/compliance-trestle

Apache License 2.0

159 stars 61 forks source link

fix: correct the argument for get_rule_key in csv_to_oscal_cd.py #1578

Closed Ma1h01 closed 3 months ago

Ma1h01 commented 3 months ago

Types of changes

[ ] Hot fix (emergency fix and release)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation (change which affects the documentation site)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Release (develop -> main)

Quality assurance (all should be covered).

[x] My code follows the code style of this project.
[x] Documentation for my change is up to date?
[x] My PR meets testing requirements.
[x] All new and existing tests passed.
[x] All commits are signed-off.

Summary

Key links:

Resolved #1576

Before you merge

Ensure it is a 'squash commit' if not a release.
Ensure CI is currently passing
Check sonar. If you are working for a fork a maintainer will reach out, if required.

AleJo2995 commented 3 months ago

@Ma1h01 you can go ahead and squash and merge this PR. Thanks