oscam-emu / oscam-patched-old

Open Source Cam Emulator
GNU General Public License v3.0
96 stars 55 forks source link

[makefile] Fixed linking of empty SoftCam.Key file on aarch64 boxes #20

Closed sattotal closed 5 years ago

sattotal commented 5 years ago

patch doesn't work on Cygwin based compilations with patch I got below errors:

ld: unknown option »-z« ld: please useoption --help for information objcopy: 'SoftCam.Key.o': No such file

oscam-emu commented 5 years ago

Please test with latest commit.

sattotal commented 5 years ago

Thanks for fast answer but the problem still exists because ld doesn't support the option -z in the Makefile

oscam-emu commented 5 years ago

Can't you upgrade/update to a version that supports the -z option?

https://stackoverflow.com/questions/29178445/what-is-the-z-option-for-in-this-gcc-compiler-command

sattotal commented 5 years ago

for Cygwin I have updated to GNU ld (GNU Binutils) 2.31.1 (latest version) . However there is no -z Option available without "-z noexecstack" I can build without error

sattotal commented 5 years ago

a possible workaround is using `

if defined(CYGWIN)

..

else

endif

`

oscam-emu commented 5 years ago

thanks will look into it, when I finished some other things I do.

oscam-emu commented 5 years ago

The linking method was reverted to the old one, so everything should be back to normal.

A new config option WITH_SOFTCAM is introduced that allows linking or not of the SoftCam.Key file during compilation.

sattotal commented 5 years ago

2078 [osemu] New config option to control SoftCam.Key linking in binary

Thanks for this well working fix ;)