oscar-broman / samp-weapon-config

A more consistent and responsive damage system with many new features
Apache License 2.0
92 stars 84 forks source link

Additional check in OnPlayerGiveDamage #163

Closed NexiusTailer closed 4 years ago

NexiusTailer commented 4 years ago

There are some fixes and other minor corrections. The main is additional check in OnPlayerGiveDamage for player state driver (if player is a driver, he doesn't send this callback and it can help to prevent hacks that spoof OnPlayerGiveDamage this way). Also I've added WC_CONST instead of just 'const' for ApplyAnimation hook. Seems like its needed here too.

NexiusTailer commented 4 years ago

Seems like the main part of changes aren't fully solved the possible OnPlayerGiveDamage spoofing (as it could be called from vehicle for some non-weapon damage reasons like 49 or 50).