All weapons that a player sends with valid issuerid in OnPlayerTakeDamage successfully being checked according to 's_ValidDamageTaken', if such damage reason cannot be valid in both Give/Take damage events, the script rejects it;
If the weaponid passed the first check (it is valid reason for both modes), we have additional checks after that, manually checking all the conditions and find if something can be wrong with each damage reason;
After those checks has passed, we still didn't check WEAPON_FLAMETHROWER and WEAPON_EXPLOSION reasons (whether the damage is reported by a player who has not even logged in? / on the other end of the map from the issuer? / other impossible conditions that we do not check at all?).
The cause of the fact I've ignored this damage reasons before and didn't add any validation for it in the previous PRs is that these reasons can be called by a victim long time after issuerid become dead (pretty easy to imagine when a player set fire to another and died himself, and the second continues to burn as long as possible). So, preventing such damage if there is a long dist between two players or if issuerid is not spawned and a long time has passed after his death means the damage would stop after your issuerid become dead or anything, even if you burn or see an grenade explosion just in front on the skin.
But the case still need to be restricted and validated anyhow, so I've decided to reset issuerid in case of failure of validation checks, like it has done in OnPlayerDeath. I think this is a good compromise to prevent the last possible bypasses from the victim's side that can cause fakekills or anything similar.
Full description of the problem:
The cause of the fact I've ignored this damage reasons before and didn't add any validation for it in the previous PRs is that these reasons can be called by a victim long time after issuerid become dead (pretty easy to imagine when a player set fire to another and died himself, and the second continues to burn as long as possible). So, preventing such damage if there is a long dist between two players or if issuerid is not spawned and a long time has passed after his death means the damage would stop after your issuerid become dead or anything, even if you burn or see an grenade explosion just in front on the skin.
But the case still need to be restricted and validated anyhow, so I've decided to reset issuerid in case of failure of validation checks, like it has done in OnPlayerDeath. I think this is a good compromise to prevent the last possible bypasses from the victim's side that can cause fakekills or anything similar.