search

oscar-broman / samp-weapon-config

A more consistent and responsive damage system with many new features
Apache License 2.0
91 stars 84 forks source link

Extending validation checks #234

Closed NexiusTailer closed 2 years ago

NexiusTailer commented 2 years ago

This change will extend validation checks for both issuerid for damagedid to be streamed for each other, not only for fire and explosion damage type as it is now, but also for any vehicle damage (hits by vehicle, hits by heli blades and car parking on damagedid). It was made because the only check for being a driver for issuerid still used by cheaters to spoof damage for all players who are driving vehicle at the moment.

ADRFranklin commented 2 years ago

Have you tested this to make sure no regressions are caused by it? The last few PR's you have made, have had regressions to some degree, so please validate it beforehand.

NexiusTailer commented 2 years ago

Yes, I saw an issue with the driver damage check when it was blocked for firing from the driver's seat. Sorry for that, this case was not noticed in time.

At this moment, provided checks has been tested and doesn't seem to be a problem here with anything.