search

oscar-broman / samp-weapon-config

A more consistent and responsive damage system with many new features
Apache License 2.0
91 stars 84 forks source link

Fall Damage #237

Open raedman90 opened 2 years ago

raedman90 commented 2 years ago

Hello, how do I activate fall damage?

NexiusTailer commented 2 years ago

It's enabled by default

raedman90 commented 2 years ago

Does not work, players do not drown or fall from great heights

ADRFranklin commented 2 years ago

Then there is a problem with your script, you are either hooking the callbacks yourself or using another library that is doing so, or you have stuff in OnPlayerDamage that is preventing it happening

raedman90 commented 2 years ago

I left an example below of what is happening

public OnPlayerDamage(&playerid, &Float:amount, &issuerid, &weapon, &bodypart) { if(issuerid != INVALID_PLAYER_ID) { //// } return 1; }

https://youtu.be/-NHpG20dMrc https://youtu.be/iaOqTg7bY0Q

I'm still doing some tests to find the problem, still ineffective

adib-yg commented 9 months ago

I have the same problem. I just added the weapon-config to a gamemode and players don't take damage from falling from heights, it was fine before I added it.

Then I started debugging. OnPlayerTakeDamage and OnPlayerGiveDamage callbacks are not called in the include when the player falls from a height. I think the data is sent from the client is overwritten by pawn.raknet.

I've tried hard to find the problem in include but can't find anything. @oscar-broman please fix this.

NexiusTailer commented 4 months ago

it does also happen only to certain clients

If all these clients are android implementations, then it's probably their problem and a subject to fix on their side