oscar-broman / samp-weapon-config

A more consistent and responsive damage system with many new features
Apache License 2.0
91 stars 84 forks source link

Minor improvements #244

Closed NexiusTailer closed 2 years ago

NexiusTailer commented 2 years ago
  1. Increased s_MaxShootRateSamples and s_MaxHitRateSamples from 3 to 4. They used in AverageShootRate (passed there as shots parameter) and AverageHitRate (passed there as hits parameter), where it subtracts 2 from their amount when the cycle starts (here and here). So, both our variables that had 3 by default becomes 1 and both functions calculate the average value based on a single shot which actually doesn't make sense having "average" word in the function names. Their default values were initially set to 5 (actually 3), but it wasn't responded very effectively to some rapid fire hacks. I think 4 (actually 2) will be better. Still don't understand why it was subtracted 2 in the cycles, but I didn't figure it out and just changed the initially set values ​​considering this thing.
  2. Added missed weapon type (WEAPON_VEHICLE_ROCKETLAUNCHER) to readme.