search

oscar-broman / samp-weapon-config

A more consistent and responsive damage system with many new features
Apache License 2.0
93 stars 83 forks source link

Add Pawn.RakNet support #245

Closed Zbyss closed 2 years ago

Zbyss commented 2 years ago

This PR adds support for Pawn.RakNet as an alternative to SKY plugin.

SKY will have a higher priority as it was main dependency for wc for years, but now there are no problems to remove it from your script entirely and just include Pawn.RakNet plugin to use weapon-config.

It allows using weapon-config on open.mp server, before an official SKY port release.

Huge thanks to @NexiusTailer for help in preparing this version.

NexiusTailer commented 2 years ago

It also makes sense now to include as much as possible omp tweaks into the main repo (into this PR as well or in the next), namely from this branch.

As for special changes, I only recommend keep "lagcompmode" console variable as in samp because it still works in omp as legacy, just change GetServerVarAsInt to GetConsoleVarAsInt when calling that.

Other corrections should work on both versions even being changed in favor of the omp server.

ADRFranklin commented 2 years ago

Just checking this is confirmed working on both sa-mp and open.mp right? Like all the general scenarios have been tested to make sure values are the same between them, etc?

NexiusTailer commented 2 years ago

The current build of omp server (bt5) blocks any 0.0 damage in OnPlayerGive/TakeDamage (reported here), but there's a response already that this will be fixed in the next released build. Any other behaviour differences weren't found by me at the moment. Perhaps @Zbyss could find something during these days of testing?

Zbyss commented 2 years ago

I haven't come across any behaviour differences during the testing phase and I haven't heard any complaints from server(s) using this version, so I assume it's fine.

ADRFranklin commented 2 years ago

I see you are still pushing fixes, I'll give you a few more days then if you are ready, I'll merge.