search

oscar-project / ungoliant

:spider: The pipeline for the OSCAR corpus
https://oscar-corpus.com
Apache License 2.0
162 stars 14 forks source link

Change sha256 to sha384 #109

Closed chris-ha458 closed 1 year ago

chris-ha458 commented 1 year ago

Changes Sha256 usage into sha384. Addresses #108

codecov[bot] commented 1 year ago

Codecov Report

Merging #109 (28b3ef0) into main (ecf9fd6) will increase coverage by 0.31%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   48.37%   48.68%   +0.31%     
==========================================
  Files          22       22              
  Lines        1135     1138       +3     
==========================================
+ Hits          549      554       +5     
+ Misses        586      584       -2
Files Changed Coverage Δ
src/processing/package.rs 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

Uinelj commented 1 year ago

As previously discussed, ungoliant should now host only pipeline code. Post-processing should (when doable) in other places, though checksumming will be integrated soon in ungoliant to enable better ergonomics around corpus generation :)

See https://github.com/oscar-project/oscar-tools/pull/43