search

oscar-system / GAP_pkg

Julia wrapper packages for GAP packages
MIT License
0 stars 0 forks source link

`browse` specific changes #10

Open fingolfin opened 1 year ago

fingolfin commented 1 year ago

GAP_pkg_browse should set up terminfo paths, see https://github.com/oscar-system/Oscar.jl/pull/1891 -- once that is done and we once we use it, we can remove the corresponding from Oscar.jl and from GAP.jl

fingolfin commented 1 year ago

So

    res = GAP.Globals.LoadPackage(GapObj("browse"), banner; OnlyNeeded=only_needed)

should become

    withenv("TERMINFO_DIRS" => joinpath(GAP.GAP_jll.Readline_jll.Ncurses_jll.find_artifact_dir(), "share", "terminfo")) do
        res = GAP.Globals.LoadPackage(GapObj("browse"), banner; OnlyNeeded=only_needed)
    end