Open fingolfin opened 1 year ago
This is even a good example: The tensor product of k-algebras should be implemented on the algebra side and simply be called from the geometry side. The way it is now, I suppose that it is implemented at several places (whereever needed).
I still think this would be useful, but we need to assign someone to do it if we really want it... Do we want it?
@HechtiDerLachs and @jankoboehm and @wdecker and @hannes14 and @afkafkafk13 and ... will design a suggestion...
For geometric constructions (e.g. taking the direct product of two varieties) it would be quite handy to have a function which computes the tensor product of two (or possibly more) polynomial rings. I'd keep it simple:
R
(and we implicitly tensor overR
)MPolyQuoRing
would be supported, I guess; if one of the arguments is of that type, the output would be as wellWe already have code in this vein. E.g. I just stumbled over this code from
experimental/IntersectionTheory/src/Main.jl
:There are proper other / better examples, I just stumbled over this. Note that it uses an internal helper function
gradings
which only really does the right thing for Z-graded groups; presumably this was done to simplify the code and avoid having to deal with products of grading groups (which I totally understand, but I think we can't avoid that in general)