`depwarn=error` (sometimes?) not working in during tests

[benlorenz]

Seen on master here: https://github.com/oscar-system/Oscar.jl/actions/runs/7341520910/job/19989355276#step:7:1818

Oscar.isgraded is deprecated, use is_graded instead.

The depwarn code seems to throw an error with a long backtrace but the tests do continue fine without any error at the end:

Test Summary:        | Pass  Total  Time
simplified complexes |    7      7  2.9s
GC: pause 124.94ms. collected 206.825177MB. incr 
Oscar.isgraded is deprecated, use is_graded instead.
Internal error: encountered unexpected error during compilation of _make_free_module:
ErrorException("deprecated binding: Oscar.isgraded")
ijl_errorf at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/rtutils.c:77
jl_binding_deprecation_warning at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/module.c:845 [inlined]
jl_binding_deprecation_warning at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/module.c:782
cg_bdw at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/codegen.cpp:2466
global_binding_pointer at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/codegen.cpp:4535
emit_globalref at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/codegen.cpp:2789
emit_expr at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/codegen.cpp:5251
emit_invoke at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/codegen.cpp:4258
emit_expr at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/codegen.cpp:5303
emit_ssaval_assign at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/codegen.cpp:4918
emit_stmtpos at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/codegen.cpp:5153 [inlined]
emit_function at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/codegen.cpp:8131
jl_emit_code at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/codegen.cpp:8478
jl_emit_codeinst at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/codegen.cpp:8526
_jl_compile_codeinst at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/jitlayers.cpp:204
jl_generate_fptr_impl at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/jitlayers.cpp:460
jl_compile_method_internal at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2348 [inlined]
jl_compile_method_internal at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2237
_jl_invoke at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2750 [inlined]
ijl_apply_generic at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2940
ResolutionModuleFactory at /home/runner/work/Oscar.jl/Oscar.jl/experimental/DoubleAndHyperComplexes/src/Morphisms/free_resolutions.jl:21
unknown function (ip: 0x7f566f5a5d59)
_jl_invoke at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2758 [inlined]
ijl_apply_generic at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2940
getindex at /home/runner/work/Oscar.jl/Oscar.jl/experimental/DoubleAndHyperComplexes/src/Objects/Attributes.jl:11
unknown function (ip: 0x7f566f5a36c6)
_jl_invoke at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2758 [inlined]
ijl_apply_generic at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2940
getindex at /home/runner/work/Oscar.jl/Oscar.jl/experimental/DoubleAndHyperComplexes/src/Objects/Types.jl:14
unknown function (ip: 0x7f566f5a3396)
_jl_invoke at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2758 [inlined]
ijl_apply_generic at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2940
free_resolution at /home/runner/work/Oscar.jl/Oscar.jl/experimental/DoubleAndHyperComplexes/src/Morphisms/free_resolutions.jl:102
unknown function (ip: 0x7f566f5a1c26)
_jl_invoke at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2758 [inlined]
ijl_apply_generic at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2940
macro expansion at /home/runner/work/Oscar.jl/Oscar.jl/experimental/DoubleAndHyperComplexes/test/simplified_complexes.jl:52 [inlined]
macro expansion at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/usr/share/julia/stdlib/v1.9/Test/src/Test.jl:1498 [inlined]
top-level scope at /home/runner/work/Oscar.jl/Oscar.jl/experimental/DoubleAndHyperComplexes/test/simplified_complexes.jl:37
jl_toplevel_eval_flex at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/toplevel.c:903
jl_toplevel_eval_flex at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/toplevel.c:856
ijl_toplevel_eval_in at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/toplevel.c:971
eval at ./boot.jl:370 [inlined]
include_string at ./loading.jl:1903
_jl_invoke at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2758 [inlined]
ijl_apply_generic at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2940
_include at ./loading.jl:1963
include at ./client.jl:478
unknown function (ip: 0x7f56d6d001a2)
_jl_invoke at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2758 [inlined]
ijl_apply_generic at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2940
jl_apply at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/julia.h:1880 [inlined]
do_call at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/interpreter.c:126
eval_value at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/interpreter.c:226
eval_stmt_value at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/interpreter.c:177 [inlined]
eval_body at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/interpreter.c:624
jl_interpret_toplevel_thunk at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/interpreter.c:762
top-level scope at /home/runner/work/Oscar.jl/Oscar.jl/experimental/DoubleAndHyperComplexes/test/runtests.jl:8
jl_toplevel_eval_flex at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/toplevel.c:912
jl_toplevel_eval_flex at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/toplevel.c:856
ijl_toplevel_eval_in at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/toplevel.c:971
eval at ./boot.jl:370 [inlined]
include_string at ./loading.jl:1903
_jl_invoke at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2758 [inlined]
ijl_apply_generic at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2940
_include at ./loading.jl:1963
include at ./Base.jl:458 [inlined]
macro expansion at ./timing.jl:501 [inlined]
#_timed_include#21 at /home/runner/work/Oscar.jl/Oscar.jl/src/utils/tests.jl:5
_timed_include at /home/runner/work/Oscar.jl/Oscar.jl/src/utils/tests.jl:1 [inlined]
_timed_include at /home/runner/work/Oscar.jl/Oscar.jl/src/utils/tests.jl:1 [inlined]
#test_module#27 at /home/runner/work/Oscar.jl/Oscar.jl/src/utils/tests.jl:151
test_module at /home/runner/work/Oscar.jl/Oscar.jl/src/utils/tests.jl:119 [inlined]
#31 at /home/runner/work/Oscar.jl/Oscar.jl/test/runtests.jl:132 [inlined]
#979 at ./asyncmap.jl:100
unknown function (ip: 0x7f56d6d99d36)
_jl_invoke at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2758 [inlined]
ijl_apply_generic at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2940
jl_apply at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/julia.h:1880 [inlined]
do_apply at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/builtins.c:730
macro expansion at ./asyncmap.jl:234 [inlined]
#995 at ./task.jl:514
unknown function (ip: 0x7f56d6d9574f)
_jl_invoke at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2758 [inlined]
ijl_apply_generic at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2940
jl_apply at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/julia.h:1880 [inlined]
start_task at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/task.c:1092
Oscar.isgraded is deprecated, use is_graded instead.
Internal error: encountered unexpected error during compilation of _make_free_module:
ErrorException("deprecated binding: Oscar.isgraded")
ijl_errorf at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/rtutils.c:77
jl_binding_deprecation_warning at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/module.c:845 [inlined]
jl_binding_deprecation_warning at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/module.c:782
cg_bdw at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/codegen.cpp:2466
global_binding_pointer at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/codegen.cpp:4535
emit_globalref at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/codegen.cpp:2789
emit_expr at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/codegen.cpp:5251
emit_call at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/codegen.cpp:4410
emit_expr at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/codegen.cpp:5321
emit_ssaval_assign at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/codegen.cpp:4918
emit_stmtpos at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/codegen.cpp:5153 [inlined]
emit_function at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/codegen.cpp:8131
jl_emit_code at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/codegen.cpp:8478
jl_emit_codeinst at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/codegen.cpp:8526
_jl_compile_codeinst at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/jitlayers.cpp:204
jl_generate_fptr_for_unspecialized_impl at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/jitlayers.cpp:512
jl_compile_method_internal at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2362 [inlined]
jl_compile_method_internal at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2237
_jl_invoke at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2750 [inlined]
ijl_apply_generic at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2940
ResolutionModuleFactory at /home/runner/work/Oscar.jl/Oscar.jl/experimental/DoubleAndHyperComplexes/src/Morphisms/free_resolutions.jl:21
unknown function (ip: 0x7f566f5a5d59)
_jl_invoke at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2758 [inlined]
ijl_apply_generic at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2940
getindex at /home/runner/work/Oscar.jl/Oscar.jl/experimental/DoubleAndHyperComplexes/src/Objects/Attributes.jl:11
unknown function (ip: 0x7f566f5a36c6)
_jl_invoke at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2758 [inlined]
ijl_apply_generic at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2940
getindex at /home/runner/work/Oscar.jl/Oscar.jl/experimental/DoubleAndHyperComplexes/src/Objects/Types.jl:14
unknown function (ip: 0x7f566f5a3396)
_jl_invoke at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2758 [inlined]
ijl_apply_generic at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2940
free_resolution at /home/runner/work/Oscar.jl/Oscar.jl/experimental/DoubleAndHyperComplexes/src/Morphisms/free_resolutions.jl:102
unknown function (ip: 0x7f566f5a1c26)
_jl_invoke at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2758 [inlined]
ijl_apply_generic at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2940
macro expansion at /home/runner/work/Oscar.jl/Oscar.jl/experimental/DoubleAndHyperComplexes/test/simplified_complexes.jl:52 [inlined]
macro expansion at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/usr/share/julia/stdlib/v1.9/Test/src/Test.jl:1498 [inlined]
top-level scope at /home/runner/work/Oscar.jl/Oscar.jl/experimental/DoubleAndHyperComplexes/test/simplified_complexes.jl:37
jl_toplevel_eval_flex at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/toplevel.c:903
jl_toplevel_eval_flex at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/toplevel.c:856
ijl_toplevel_eval_in at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/toplevel.c:971
eval at ./boot.jl:370 [inlined]
include_string at ./loading.jl:1903
_jl_invoke at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2758 [inlined]
ijl_apply_generic at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2940
_include at ./loading.jl:1963
include at ./client.jl:478
unknown function (ip: 0x7f56d6d001a2)
_jl_invoke at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2758 [inlined]
ijl_apply_generic at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2940
jl_apply at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/julia.h:1880 [inlined]
do_call at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/interpreter.c:126
eval_value at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/interpreter.c:226
eval_stmt_value at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/interpreter.c:177 [inlined]
eval_body at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/interpreter.c:624
jl_interpret_toplevel_thunk at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/interpreter.c:762
top-level scope at /home/runner/work/Oscar.jl/Oscar.jl/experimental/DoubleAndHyperComplexes/test/runtests.jl:8
jl_toplevel_eval_flex at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/toplevel.c:912
jl_toplevel_eval_flex at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/toplevel.c:856
ijl_toplevel_eval_in at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/toplevel.c:971
eval at ./boot.jl:370 [inlined]
include_string at ./loading.jl:1903
_jl_invoke at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2758 [inlined]
ijl_apply_generic at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2940
_include at ./loading.jl:1963
include at ./Base.jl:458 [inlined]
macro expansion at ./timing.jl:501 [inlined]
#_timed_include#21 at /home/runner/work/Oscar.jl/Oscar.jl/src/utils/tests.jl:5
_timed_include at /home/runner/work/Oscar.jl/Oscar.jl/src/utils/tests.jl:1 [inlined]
_timed_include at /home/runner/work/Oscar.jl/Oscar.jl/src/utils/tests.jl:1 [inlined]
#test_module#27 at /home/runner/work/Oscar.jl/Oscar.jl/src/utils/tests.jl:151
test_module at /home/runner/work/Oscar.jl/Oscar.jl/src/utils/tests.jl:119 [inlined]
#31 at /home/runner/work/Oscar.jl/Oscar.jl/test/runtests.jl:132 [inlined]
#979 at ./asyncmap.jl:100
unknown function (ip: 0x7f56d6d99d36)
_jl_invoke at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2758 [inlined]
ijl_apply_generic at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2940
jl_apply at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/julia.h:1880 [inlined]
do_apply at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/builtins.c:730
macro expansion at ./asyncmap.jl:234 [inlined]
#995 at ./task.jl:514
unknown function (ip: 0x7f56d6d9574f)
_jl_invoke at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2758 [inlined]
ijl_apply_generic at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/gf.c:2940
jl_apply at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/julia.h:1880 [inlined]
start_task at /cache/build/builder-amdci4-4/julialang/julia-release-1-dot-9/src/task.c:1092
Test Summary:         | Pass  Total  Time
determinantal surface |   10     10  6.4s

The call triggering this is here but we can probably leave this until we understand why the depwarn check is not working.

[thofma]

I have seen "internal errors" in type inference/compilation before. For some reasons I don't understand, these are sometimes just ignored and the program continues. Like here: https://github.com/JuliaLang/Pkg.jl/issues/2927. Might be due to the use of Base.@deprecate_binding instead of @deprecate? Not sure though

[fingolfin]

Maybe this is https://github.com/JuliaLang/julia/issues/46354 ?

No, I don't think so

[fingolfin]

Looking at a current master report, I still see

Oscar.SimpleGlueing is deprecated, use SimpleGluing instead.
Internal error: encountered unexpected error during compilation of _compute_inherited_gluing:
ErrorException("use of deprecated variable: Oscar.SimpleGlueing")

Should @HechtiDerLachs fix that, or should it stay in to "help debug the issue"? Although... if we want to debug this, it would be easy enough to create a branch that adds such a use back in, wouldn't it? In that sense I think @HechtiDerLachs should just fix it