search

oscar-system / Oscar.jl

A comprehensive open source computer algebra system for computations in algebra, geometry, and number theory.
https://www.oscar-system.org
Other
338 stars 120 forks source link

polynomial_ring cached=false for combinatorics #3856

Closed ederc closed 1 week ago

ederc commented 3 months ago

Some tests have now problems with different parent rings, see discussion at #2455.

Maybe @bschroter can help fixing the tests?

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 79.16667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.66%. Comparing base (bb60d2a) to head (91095bd). Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...binatorics/Matroids/matroid_strata_grassmannian.jl 0.00% 2 Missing :warning:
src/Combinatorics/Matroids/properties.jl 89.47% 2 Missing :warning:
src/Combinatorics/Matroids/ChowRings.jl 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3856 +/- ## ========================================== - Coverage 84.67% 84.66% -0.02% ========================================== Files 626 626 Lines 84207 84211 +4 ========================================== - Hits 71306 71295 -11 - Misses 12901 12916 +15 ``` | [Files with missing lines](https://app.codecov.io/gh/oscar-system/Oscar.jl/pull/3856?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oscar-system) | Coverage Δ | | |---|---|---| | [src/Combinatorics/Matroids/ChowRings.jl](https://app.codecov.io/gh/oscar-system/Oscar.jl/pull/3856?src=pr&el=tree&filepath=src%2FCombinatorics%2FMatroids%2FChowRings.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oscar-system#diff-c3JjL0NvbWJpbmF0b3JpY3MvTWF0cm9pZHMvQ2hvd1JpbmdzLmps) | `99.20% <66.66%> (ø)` | | | [...binatorics/Matroids/matroid\_strata\_grassmannian.jl](https://app.codecov.io/gh/oscar-system/Oscar.jl/pull/3856?src=pr&el=tree&filepath=src%2FCombinatorics%2FMatroids%2Fmatroid_strata_grassmannian.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oscar-system#diff-c3JjL0NvbWJpbmF0b3JpY3MvTWF0cm9pZHMvbWF0cm9pZF9zdHJhdGFfZ3Jhc3NtYW5uaWFuLmps) | `0.00% <0.00%> (ø)` | | | [src/Combinatorics/Matroids/properties.jl](https://app.codecov.io/gh/oscar-system/Oscar.jl/pull/3856?src=pr&el=tree&filepath=src%2FCombinatorics%2FMatroids%2Fproperties.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oscar-system#diff-c3JjL0NvbWJpbmF0b3JpY3MvTWF0cm9pZHMvcHJvcGVydGllcy5qbA==) | `98.34% <89.47%> (-0.83%)` | :arrow_down: | ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/oscar-system/Oscar.jl/pull/3856/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oscar-system)