Closed ThomasBreuer closed 4 hours ago
Thank you!
This behaviour of recog is not nice, the people who invented it did probably not think of the situation that the package gets installed automatically by PackageManager
They absolutely did not, because when I added regen_doc.g
in 2017, PackageManager did not even exist :-). And to this day nobody apparently tried to install recog via PackageManager either (or at least they did not bother to write an issue for recog
), otherwise "we" would have looked into fixing it long ago. (Though looking at the changes you made, they seem to me more like a workaround for a bug in PackageManager than a fix? Note that makedoc.g in virtually all GAP packages really expects to be run from the directory it lives in; that it apparently often works otherwise as well is just luck (whether good or bad luck is a matter of opinion, after all it hid the bug in PackageManager for a long time)
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 83.87%. Comparing base (
5acca40
) to head (2fce1d5
). Report is 3 commits behind head on master.
Return to the situation where the released version of GAP's
recog
package gets installed if necessary, not a current version from github.We keep the change that the
OscarInterface
package gets loaded in the end, and that it requires thePolycyclic
package.I think that once there will be a new released
recog
version, theinstall
call forrecog
in Oscar will run into an error unless we are then able to start GAP without loaded packages. The point is that if a version is already loaded that lies in a path different from the path of the newly installed version, the GAP code inrecog
that gets called for processing the documentation will throw an error. This behaviour ofrecog
is not nice, the people who invented it did probably not think of the situation that the package gets installed automatically byPackageManager
.