search

oscar-system / Oscar.jl

A comprehensive open source computer algebra system for computations in algebra, geometry, and number theory.
https://www.oscar-system.org
Other
338 stars 120 forks source link

Remove caching of Lie algebras #3894

Closed lgoettgens closed 3 months ago

lgoettgens commented 3 months ago

Apart from the usual problems with caching (x-ref e.g. https://github.com/oscar-system/Oscar.jl/issues/2455), I noticed that the caches for Lie algebras have very extended keys: for linear Lie algebras, a whole basis was part of the cache-key, while for abstract lie algebras the structure constant table. Both are IMO too enormous to take as a key here. Furthermore, I cannot come up with any non-trivial (interactive) example where one really needs this kind of caching.

Aside from this, fixed some minor things in docstrings, and with correct propagation of check kwargs.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.91%. Comparing base (5acca40) to head (bf5979d). Report is 6 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3894 +/- ## ========================================== + Coverage 83.87% 83.91% +0.04% ========================================== Files 589 589 Lines 80864 81301 +437 ========================================== + Hits 67823 68224 +401 - Misses 13041 13077 +36 ``` | [Files](https://app.codecov.io/gh/oscar-system/Oscar.jl/pull/3894?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oscar-system) | Coverage Δ | | |---|---|---| | [experimental/LieAlgebras/src/AbstractLieAlgebra.jl](https://app.codecov.io/gh/oscar-system/Oscar.jl/pull/3894?src=pr&el=tree&filepath=experimental%2FLieAlgebras%2Fsrc%2FAbstractLieAlgebra.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oscar-system#diff-ZXhwZXJpbWVudGFsL0xpZUFsZ2VicmFzL3NyYy9BYnN0cmFjdExpZUFsZ2VicmEuamw=) | `73.39% <100.00%> (-0.25%)` | :arrow_down: | | [experimental/LieAlgebras/src/LieAlgebras.jl](https://app.codecov.io/gh/oscar-system/Oscar.jl/pull/3894?src=pr&el=tree&filepath=experimental%2FLieAlgebras%2Fsrc%2FLieAlgebras.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oscar-system#diff-ZXhwZXJpbWVudGFsL0xpZUFsZ2VicmFzL3NyYy9MaWVBbGdlYnJhcy5qbA==) | `100.00% <ø> (ø)` | | | [experimental/LieAlgebras/src/LinearLieAlgebra.jl](https://app.codecov.io/gh/oscar-system/Oscar.jl/pull/3894?src=pr&el=tree&filepath=experimental%2FLieAlgebras%2Fsrc%2FLinearLieAlgebra.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oscar-system#diff-ZXhwZXJpbWVudGFsL0xpZUFsZ2VicmFzL3NyYy9MaW5lYXJMaWVBbGdlYnJhLmps) | `94.01% <100.00%> (-0.04%)` | :arrow_down: | | [experimental/LieAlgebras/src/iso\_gap\_oscar.jl](https://app.codecov.io/gh/oscar-system/Oscar.jl/pull/3894?src=pr&el=tree&filepath=experimental%2FLieAlgebras%2Fsrc%2Fiso_gap_oscar.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oscar-system#diff-ZXhwZXJpbWVudGFsL0xpZUFsZ2VicmFzL3NyYy9pc29fZ2FwX29zY2FyLmps) | `100.00% <100.00%> (ø)` | | | [experimental/LieAlgebras/src/LieAlgebra.jl](https://app.codecov.io/gh/oscar-system/Oscar.jl/pull/3894?src=pr&el=tree&filepath=experimental%2FLieAlgebras%2Fsrc%2FLieAlgebra.jl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oscar-system#diff-ZXhwZXJpbWVudGFsL0xpZUFsZ2VicmFzL3NyYy9MaWVBbGdlYnJhLmps) | `86.16% <0.00%> (ø)` | | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/oscar-system/Oscar.jl/pull/3894/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oscar-system)