oscar-system / Oscar.jl

A comprehensive open source computer algebra system for computations in algebra, geometry, and number theory.
https://www.oscar-system.org
Other
345 stars 126 forks source link

either characteristic or equality test in localizations of quotients is lying #4324

Open thofma opened 2 hours ago

thofma commented 2 hours ago

@HechtiDerLachs For the ring

julia> Qxyz, (x, y, z) = QQ["x", "y", "z"];

julia> I = ideal(Qxyz, x^2 - x, x * y);

julia> Q, = quo(Qxyz, I);

julia> L, = localization(Q, powers_of_element(x) * powers_of_element(x - 1));

I get

julia> iszero(one(L))
true

julia> characteristic(L)
0

Any idea what could be wrong?

P.S.: I got this from an example in the geometry tests, while looking for usages of the zero ring.

thofma commented 2 hours ago

I guess the multiplicative set contains zero, so the characteristic is wrong.

fingolfin commented 1 hour ago

yeah, this method is overly optimistic:

characteristic(W::AbsLocalizedRing) = characteristic(base_ring(W))