search

oscar-system / Oscar.jl

A comprehensive open source computer algebra system for computations in algebra, geometry, and number theory.
https://www.oscar-system.org
Other
366 stars 129 forks source link

Missing `eigenvalues` for matrices over integers #4330

Open fingolfin opened 1 week ago

fingolfin commented 1 week ago

Just stumbled over this when demoing OSCAR:

julia> eigenvalues(identity_matrix(ZZ,3))
ERROR: MethodError: no method matching eigvals(::ZZMatrix)
The function `eigvals` exists, but no method is defined for this combination of argument types.
lgoettgens commented 1 week ago

We seem to have generic eigenvalue machinery in https://github.com/lgoettgens/Nemo.jl/blob/52ef106a39f4c37830756cb45411401fd8bcdcbc/src/matrix.jl#L206-L293, but this is restricted to MatElem{<:FieldElem}.

thofma commented 4 days ago

I see no harm widening the signature for the eigenvalue* functions to allow RingElem.