search

oscar-system / Polymake.jl

Interface to Polymake using CxxWrap
Other
25 stars 17 forks source link

Fix precompilation warnings downstream #466

Closed thofma closed 6 months ago

thofma commented 6 months ago

Fixes https://github.com/thofma/Hecke.jl/issues/1340 for me (see also https://github.com/JuliaLang/julia/issues/52685).

If you are happy with this, I would also appreciate a quick patch release containing this fix.

benlorenz commented 6 months ago

I don't think this is a good solution, as pointed out here https://github.com/JuliaLang/julia/pull/50914#issuecomment-1714559096 this could cause issues with packages using Polymake.jl which expect polymake to be initialized correctly during precompilation.

benlorenz commented 6 months ago

Note that we are even running the Aqua test regarding this issue during CI:

  Persistent tasks                           |    1      1   6.4s
benlorenz commented 6 months ago

I reverted your commit and added a different workaround for this by setting a custom Downloads.Downloader with a short grace time. This should avoid the hang due to the timer.

thofma commented 6 months ago

Thanks!