Open fingolfin opened 3 weeks ago
Maybe use option 3 for a fast fix, I'm not sure how fast option 2 can be done.
Option 3 might not work in all cases because new jll + old Singular.jl
will still be a valid resolution for the package manager and not much different from old jll + new Singular.jl
.
I think the call isequal(B, Ideal(x ^ 2 + x * y + 1, 2 * y ^ 2 + 3))
was also invalid before the update (missing the R
argument), the main issue seems to be that this is not equal anymore:
julia> R, (x, y) = polynomial_ring(QQ, ["x", "y"])
(Singular polynomial ring (QQ),(x,y),(dp(2),C), spoly{n_Q}[x, y])
julia> I = Ideal(R, x^2 + x*y + 1, 2y^2 + 3)
Singular ideal over Singular polynomial ring (QQ),(x,y),(dp(2),C) with generators (x^2 + x*y + 1, 2*y^2 + 3)
julia> B = slimgb(I, complete_reduction=false)
Singular ideal over Singular polynomial ring (QQ),(x,y),(dp(2),C) with generators (y^2 + 3//2, x^2 + x*y + 1)
julia> isequal(B, Ideal(R, 2 * y ^ 2 + 3, x ^ 2 + x * y + 1))
false
Before the update the coefficients in B
were not normalized like that:
julia> B = slimgb(I, complete_reduction=false)
Singular ideal over Singular polynomial ring (QQ),(x,y),(dp(2),C) with generators (2*y^2 + 3, x^2 + x*y + 1)
julia> isequal(B, Ideal(R, 2 * y ^ 2 + 3, x ^ 2 + x * y + 1))
true
And this normalization issue looks very similar to the doctest failure in Oscar (e.g. in #3889): https://github.com/oscar-system/Oscar.jl/actions/runs/9704350563/job/26795722745?pr=3889#step:8:3878
│ Evaluated output:
│
│ Gröbner basis with elements
│ 1 -> x*y - 3*x
│ 2 -> y^3 - 6*x^2
│ 3 -> x^3 - 9//2*x
│ with respect to the ordering
│ degrevlex([x, y])
│
│ Expected output:
│
│ Gröbner basis with elements
│ 1 -> x*y - 3*x
│ 2 -> y^3 - 6*x^2
│ 3 -> 2*x^3 - 9*x
│ with respect to the ordering
│ degrevlex([x, y])
Also it looks like the booktests are getting stuck during algebraic-geometry/zariski.jlcon
now, maybe this is also related but I haven't really looked into it.
I vote for option 2, as now there are fixes to the option handling in libsingular: resetting options must be done after resetting the ring
The Singular.jl CI tests started to fail. Nothing in Singular.jl changed, but there is a new Singular_jll release which is
If I downgrade Singular_jll from v404.0.301 to v404.0.100 it works.
Possible solutions:
0.1.0
or so~404.000.301
, and make a quick releaseSingular_jll compat
=404.000.100` and make a quick release.@hannes14 I can't judge how hard/easy option 2 would be. Which should we try?